]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mkimage: Require a data file when auto-fit is used
authorSimon Glass <sjg@chromium.org>
Thu, 30 Jun 2016 16:52:09 +0000 (10:52 -0600)
committerTom Rini <trini@konsulko.com>
Thu, 14 Jul 2016 22:22:27 +0000 (18:22 -0400)
When auto-fit is used, it is not valid to create a FIT without an image
file. Add a check for this to avoid a very confusing error message later
("Can't open (null): Bad address").

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
tools/mkimage.c

index 66d29abbb0eada7e06e13baa643b9bd38c093ed0..a36c031159f1c156749b1207759016090a570b38 100644 (file)
@@ -276,6 +276,8 @@ static void process_args(int argc, char **argv)
                /* For auto_its, datafile is always 'auto' */
                if (!params.auto_its)
                        params.datafile = datafile;
+               else if (!params.datafile)
+                       usage("Missing data file for auto-FIT (use -d)");
        } else if (type != IH_TYPE_INVALID) {
                params.type = type;
        }