]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
efi_loader: remove duplicate assignment
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 1 Apr 2023 05:21:55 +0000 (07:21 +0200)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 1 Apr 2023 08:11:50 +0000 (10:11 +0200)
Assigning the value of a variable to itself should be avoided.

Addresses-Coverity-ID: 451089 ("Evaluation order violation")
Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
lib/efi_loader/efi_device_path.c

index f35f673ce63d954674bb1f9a7b0f69369a513f46..8a65dda8838cc9889c3a02d10b2b53be47c9aa35 100644 (file)
@@ -740,7 +740,7 @@ __maybe_unused static void *dp_fill(void *buf, struct udevice *dev)
 #endif
 #if defined(CONFIG_USB)
                case UCLASS_MASS_STORAGE: {
-                       struct blk_desc *desc = desc = dev_get_uclass_plat(dev);
+                       struct blk_desc *desc = dev_get_uclass_plat(dev);
                        struct efi_device_path_controller *dp =
                                dp_fill(buf, dev->parent);