]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: cdns3: avoid error messages if phys don't exist
authorRoger Quadros <rogerq@kernel.org>
Fri, 12 Jan 2024 12:49:48 +0000 (14:49 +0200)
committerTom Rini <trini@konsulko.com>
Sat, 20 Jan 2024 16:38:18 +0000 (11:38 -0500)
The phys property is optional so don't complain
if it doesn't exist in device tree.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
drivers/usb/cdns3/core.c

index 644a9791b9c9fbb6a0467e05d0cea2f062390e5b..12a741c6ea7c4e376494a3cc29bebe5323220021 100644 (file)
@@ -333,20 +333,28 @@ static int cdns3_probe(struct cdns3 *cdns)
        mutex_init(&cdns->mutex);
 
        ret = generic_phy_get_by_name(dev, "cdns3,usb2-phy", &cdns->usb2_phy);
-       if (ret)
-               dev_warn(dev, "Unable to get USB2 phy (ret %d)\n", ret);
-
-       ret = generic_phy_init(&cdns->usb2_phy);
-       if (ret)
+       if (!ret) {
+               ret = generic_phy_init(&cdns->usb2_phy);
+               if (ret) {
+                       dev_err(dev, "USB2 PHY init failed: %d\n", ret);
+                       return ret;
+               }
+       } else if (ret != -ENOENT && ret != -ENODATA) {
+               dev_err(dev, "Couldn't get USB2 PHY:  %d\n", ret);
                return ret;
+       }
 
        ret = generic_phy_get_by_name(dev, "cdns3,usb3-phy", &cdns->usb3_phy);
-       if (ret)
-               dev_warn(dev, "Unable to get USB3 phy (ret %d)\n", ret);
-
-       ret = generic_phy_init(&cdns->usb3_phy);
-       if (ret)
+       if (!ret) {
+               ret = generic_phy_init(&cdns->usb3_phy);
+               if (ret) {
+                       dev_err(dev, "USB3 PHY init failed: %d\n", ret);
+                       return ret;
+               }
+       } else if (ret != -ENOENT && ret != -ENODATA) {
+               dev_err(dev, "Couldn't get USB3 PHY:  %d\n", ret);
                return ret;
+       }
 
        ret = generic_phy_power_on(&cdns->usb2_phy);
        if (ret)