]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
colibri-imx7: specify MTD partitions on command line
authorFrancesco Dolcini <francesco.dolcini@toradex.com>
Mon, 6 Feb 2023 22:48:37 +0000 (23:48 +0100)
committerDario Binacchi <dario.binacchi@amarulasolutions.com>
Sun, 16 Apr 2023 12:18:13 +0000 (14:18 +0200)
Disable fdt_fixup_mtdparts() and pass MTD partition on the command
line. Dynamically editing the fdt with a static partitions configuration
is not required and there is no advantages compared to using the command
line. This change should prevent boot failures as the one in [0].

Cc: Marek Vasut <marex@denx.de>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/
Link: https://lore.kernel.org/all/20230105123334.7f90c289@xps-13/
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Link: https://lore.kernel.org/all/20230206224838.75963-3-francesco@dolcini.it/
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
board/toradex/colibri_imx7/colibri_imx7.c
configs/colibri_imx7_defconfig
include/configs/colibri_imx7.h

index 6ce4fa376ac025fb55a604b9a93920b07209b450..3e79ab93a982d6f2b229c4147b41375de9f1a17a 100644 (file)
@@ -303,16 +303,6 @@ int ft_board_setup(void *blob, struct bd_info *bd)
                        fdt_status_disabled(blob, off);
        }
 #endif
-#if defined(CONFIG_FDT_FIXUP_PARTITIONS)
-       static const struct node_info nodes[] = {
-               { "fsl,imx7d-gpmi-nand", MTD_DEV_TYPE_NAND, }, /* NAND flash */
-               { "fsl,imx6q-gpmi-nand", MTD_DEV_TYPE_NAND, },
-       };
-
-       /* Update partition nodes using info from mtdparts env var */
-       puts("   Updating MTD partitions...\n");
-       fdt_fixup_mtdparts(blob, nodes, ARRAY_SIZE(nodes));
-#endif
 
        return ft_common_board_setup(blob, bd);
 }
index 3a67ea385086ad56c6931b95470fb1fe6acf96a8..8439742afaae1b73f28d22595f21af978d3810b4 100644 (file)
@@ -102,4 +102,3 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x4000
 CONFIG_CI_UDC=y
 CONFIG_USB_GADGET_DOWNLOAD=y
 CONFIG_OF_LIBFDT_OVERLAY=y
-CONFIG_FDT_FIXUP_PARTITIONS=y
index c568643977ca3e0009f18580c1384a5333905cd7..03f8ed14787ac673daf9f31a9d77ef6e90994222 100644 (file)
                "${board}/flash_blk.img && source ${loadaddr}\0" \
        "setup=setenv setupargs " \
                "console=tty1 console=${console}" \
-               ",${baudrate}n8 ${memargs} consoleblank=0\0" \
+               ",${baudrate}n8 ${memargs} ${mtdparts} consoleblank=0\0" \
        "setupdate=run setsdupdate || run setusbupdate || run setethupdate\0" \
        "setusbupdate=usb start && setenv interface usb && " \
                "fatload ${interface} 0:1 ${loadaddr} " \