dm: error handling dev_get_dma_range()

goto after return has not effect. Calling of_node_put() in case of some
errors and not for others is inconsistent.

Fixes: 51bdb50904b ("dm: Introduce xxx_get_dma_range()")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/drivers/core/of_addr.c b/drivers/core/of_addr.c
index 5bc6ca1de01320d1331f655410328cb9647433a1..b3e384d2ee17cc6f25efa2a3056c9ddeeb0e18cb 100644 (file)
--- a/drivers/core/of_addr.c
+++ b/drivers/core/of_addr.c
@@ -372,7 +372,7 @@ int of_get_dma_range(const struct device_node *dev, phys_addr_t *cpu,
        bus_node->count_cells(dev, &na, &ns);
        if (!OF_CHECK_COUNTS(na, ns)) {
                printf("Bad cell count for %s\n", of_node_full_name(dev));
-               return -EINVAL;
+               ret = -EINVAL;
                goto out_parent;
        }
 
@@ -380,7 +380,7 @@ int of_get_dma_range(const struct device_node *dev, phys_addr_t *cpu,
        bus_node->count_cells(parent, &pna, &pns);
        if (!OF_CHECK_COUNTS(pna, pns)) {
                printf("Bad cell count for %s\n", of_node_full_name(parent));
-               return -EINVAL;
+               ret = -EINVAL;
                goto out_parent;
        }