tools: mkenvimage: Fix possible segfault on stdin input

The size of 'filebuf' was not increased as more and more bytes are read
from stdin, but 'filebuf' was always reallocated to the same fix size.
This works as long as only less bytes than the initial buffer size come
in, for more input this will segfault. (It actually does, I tested
that.) So for each loop cycle the buffer size has to be increased by the
number of bytes we want to read.

Signed-off-by: Alexander Dahl <ada@thorsis.com>

diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
index 716cb73a5c63b70d18943e0e9629eb22d9c5965b..8cd9ffa1c6a5f4386e4449446958f612b832b638 100644 (file)
--- a/tools/mkenvimage.c
+++ b/tools/mkenvimage.c
@@ -162,7 +162,7 @@ int main(int argc, char **argv)
                txt_fd = STDIN_FILENO;
 
                do {
-                       filebuf = realloc(filebuf, readlen);
+                       filebuf = realloc(filebuf, filesize + readlen);
                        if (!filebuf) {
                                fprintf(stderr, "Can't realloc memory for the input file buffer\n");
                                return EXIT_FAILURE;