common: board_r: Drop initr_pci wrapper

Add a return value to pci_init and use it directly in the post-relocation
init sequence, rather than using a wrapper stub.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/common/board_r.c b/common/board_r.c
index d86ff0cb5e9f412675f51d4ea0ed80e972878e7b..414b6272c5ac4d0bac66110806c4db0ed27efebf 100644 (file)
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -214,16 +214,6 @@ static int initr_unlock_ram_in_cache(void)
 }
 #endif
 
-#ifdef CONFIG_PCI
-static int initr_pci(void)
-{
-       if (IS_ENABLED(CONFIG_PCI_INIT_R))
-               pci_init();
-
-       return 0;
-}
-#endif
-
 static int initr_barrier(void)
 {
 #ifdef CONFIG_PPC
@@ -732,12 +722,12 @@ static init_fnc_t init_sequence_r[] = {
        post_output_backlog,
 #endif
        INIT_FUNC_WATCHDOG_RESET
-#if defined(CONFIG_PCI) && defined(CONFIG_SYS_EARLY_PCI_INIT)
+#if defined(CONFIG_PCI_INIT_R) && defined(CONFIG_SYS_EARLY_PCI_INIT)
        /*
         * Do early PCI configuration _before_ the flash gets initialised,
         * because PCU resources are crucial for flash access on some boards.
         */
-       initr_pci,
+       pci_init,
 #endif
 #ifdef CONFIG_ARCH_EARLY_INIT_R
        arch_early_init_r,
@@ -776,11 +766,11 @@ static init_fnc_t init_sequence_r[] = {
        mac_read_from_eeprom,
 #endif
        INIT_FUNC_WATCHDOG_RESET
-#if defined(CONFIG_PCI) && !defined(CONFIG_SYS_EARLY_PCI_INIT)
+#if defined(CONFIG_PCI_INIT_R) && !defined(CONFIG_SYS_EARLY_PCI_INIT)
        /*
         * Do pci configuration
         */
-       initr_pci,
+       pci_init,
 #endif
        stdio_add_devices,
        initr_jumptable,

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index 4cdd06b1257d00ccee3727b88c18c33daf5ed52f..ba65f47e808b048853b2ffc56e0b956f36e05326 100644 (file)
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -1842,7 +1842,7 @@ U_BOOT_DRIVER(pci_generic_drv) = {
        .of_match       = pci_generic_ids,
 };
 
-void pci_init(void)
+int pci_init(void)
 {
        struct udevice *bus;
 
@@ -1855,4 +1855,6 @@ void pci_init(void)
             uclass_next_device_check(&bus)) {
                ;
        }
+
+       return 0;
 }

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 664e8379eb550c717740017885789a5c6221a158..a7453e57552be98a0aa0859e8a959e5614c99674 100644 (file)
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -454,16 +454,18 @@ int pci_hose_scan(struct pci_controller *hose)
        return pci_hose_scan_bus(hose, hose->current_busno);
 }
 
-void pci_init(void)
+int pci_init(void)
 {
        hose_head = NULL;
 
        /* allow env to disable pci init/enum */
        if (env_get("pcidisable") != NULL)
-               return;
+               return 0;
 
        /* now call board specific pci_init()... */
        pci_init_board();
+
+       return 0;
 }
 
 /* Returns the address of the requested capability structure within the

diff --git a/include/init.h b/include/init.h
index c6c5f34b55aa6c10a77c9e0da2f434fc9412c7f6..dded1cb871caa7e7610308df79ab9e71fa49c5bd 100644 (file)
--- a/include/init.h
+++ b/include/init.h
@@ -186,6 +186,18 @@ int cpu_secondary_init_r(void);
  */
 int pci_ep_init(void);
 
+/**
+ * pci_init() - Enumerate pci devices
+ *
+ * It is called during the generic post-relocation init sequence to enumerate
+ * pci buses. This is needed, for instance, in the case of DM PCI-based
+ * Ethernet devices, which will not be detected without having the enumeration
+ * performed earlier.
+ *
+ * Return: 0 if OK
+ */
+int pci_init(void);
+
 /**
  * init_cache_f_r() - Turn on the cache in preparation for relocation
  *
@@ -257,7 +269,6 @@ int mac_read_from_eeprom(void);
 int set_cpu_clk_info(void);
 int update_flash_size(int flash_size);
 int arch_early_init_r(void);
-void pci_init(void);
 int misc_init_r(void);
 #if defined(CONFIG_VID)
 int init_func_vid(void);