image: Convert fit_image_hash_set_value() to static, and rename

This function doesn't need to be exported, and with verification
we want to use it for setting the 'value' property in any node,
so rename it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>

diff --git a/include/image.h b/include/image.h
index 21d92137e8b85233e4c09413bfffe062b5e04aae..dc8f8b10c4900f3593ac08e77b4bdd981907dd53 100644 (file)
--- a/include/image.h
+++ b/include/image.h
@@ -614,8 +614,6 @@ int fit_image_hash_get_ignore(const void *fit, int noffset, int *ignore);
 int fit_set_timestamp(void *fit, int noffset, time_t timestamp);
 int fit_set_hashes(void *fit);
 int fit_image_set_hashes(void *fit, int image_noffset);
-int fit_image_hash_set_value(void *fit, int noffset, uint8_t *value,
-                               int value_len);
 
 int fit_image_check_hashes(const void *fit, int noffset);
 int fit_all_image_check_hashes(const void *fit);

diff --git a/tools/image-host.c b/tools/image-host.c
index 6648215981d905905dce0a46223330427ce456f5..a6b4f6ba0cb4ea5b2626ad998a1c6380c8e085e1 100644 (file)
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -78,6 +78,36 @@ int fit_set_hashes(void *fit)
        return 0;
 }
 
+/**
+ * fit_set_hash_value - set hash value in requested has node
+ * @fit: pointer to the FIT format image header
+ * @noffset: hash node offset
+ * @value: hash value to be set
+ * @value_len: hash value length
+ *
+ * fit_set_hash_value() attempts to set hash value in a node at offset
+ * given and returns operation status to the caller.
+ *
+ * returns
+ *     0, on success
+ *     -1, on failure
+ */
+static int fit_set_hash_value(void *fit, int noffset, uint8_t *value,
+                               int value_len)
+{
+       int ret;
+
+       ret = fdt_setprop(fit, noffset, FIT_VALUE_PROP, value, value_len);
+       if (ret) {
+               printf("Can't set hash '%s' property for '%s' node(%s)\n",
+                      FIT_VALUE_PROP, fit_get_name(fit, noffset, NULL),
+                      fdt_strerror(ret));
+               return -1;
+       }
+
+       return 0;
+}
+
 /**
  * fit_image_process_hash - Process a single subnode of the images/ node
  *
@@ -119,7 +149,7 @@ static int fit_image_process_hash(void *fit, const char *image_name,
                return -1;
        }
 
-       if (fit_image_hash_set_value(fit, noffset, value, value_len)) {
+       if (fit_set_hash_value(fit, noffset, value, value_len)) {
                printf("Can't set hash value for '%s' hash node in '%s' image node\n",
                       fit_get_name(fit, noffset, NULL), image_name);
                return -1;
@@ -187,33 +217,3 @@ int fit_image_set_hashes(void *fit, int image_noffset)
 
        return 0;
 }
-
-/**
- * fit_image_hash_set_value - set hash value in requested has node
- * @fit: pointer to the FIT format image header
- * @noffset: hash node offset
- * @value: hash value to be set
- * @value_len: hash value length
- *
- * fit_image_hash_set_value() attempts to set hash value in a node at offset
- * given and returns operation status to the caller.
- *
- * returns
- *     0, on success
- *     -1, on failure
- */
-int fit_image_hash_set_value(void *fit, int noffset, uint8_t *value,
-                               int value_len)
-{
-       int ret;
-
-       ret = fdt_setprop(fit, noffset, FIT_VALUE_PROP, value, value_len);
-       if (ret) {
-               printf("Can't set hash '%s' property for '%s' node(%s)\n",
-                      FIT_VALUE_PROP, fit_get_name(fit, noffset, NULL),
-                      fdt_strerror(ret));
-               return -1;
-       }
-
-       return 0;
-}