]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
reset: fix reset_get_by_index_nodev index handling
authorNeil Armstrong <narmstrong@baylibre.com>
Tue, 20 Apr 2021 08:42:26 +0000 (10:42 +0200)
committerStefan Roese <sr@denx.de>
Wed, 28 Apr 2021 08:05:13 +0000 (10:05 +0200)
This fixes an issue getting resets index 1 and 3+, the spurius "> 0"
made it return the index 0 or 1, whatever index was passed.

The dm_test_reset_base() did not catch it, but the dm_test_reset_base() extension
catches it and this fixes the regression.

This also fixes a reggression on Amlogic G12A/G12B SoCs, where HDMI output was disable
even when Linux was booting.

Fixes: ea9dc35aab ("reset: Get the RESET by index without device")
Reported-by: B1oHazard <ty3uk@mail.ua>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
drivers/reset/reset-uclass.c

index 071c389ca073baf975ed8ba47c07023370cdb8ce..ac89eaf098ab20c16a8fd91cd2823c0534f6f3da 100644 (file)
@@ -95,7 +95,7 @@ int reset_get_by_index_nodev(ofnode node, int index,
        int ret;
 
        ret = ofnode_parse_phandle_with_args(node, "resets", "#reset-cells", 0,
-                                            index > 0, &args);
+                                            index, &args);
 
        return reset_get_by_index_tail(ret, node, &args, "resets",
                                       index > 0, reset_ctl);