bcmgenet, sun8i_emac: Don't connect PHY two times

The bcmgenet and sun8i_emac drivers call phy_connect(), which finds /
creates the PHY and also connects it to the eth device via
phy_connect_dev(), then set some phydev members (bcmgenet only), and
then call phy_connect_dev() explicitly again.

Drop the second phy_connect_dev(), since it is unnecesary.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

diff --git a/drivers/net/bcmgenet.c b/drivers/net/bcmgenet.c
index ef321f283999621b12c99971833f438a85d7f127..4e1f8ed7a4ad5555091fd2374c133c623e95d4e2 100644 (file)
--- a/drivers/net/bcmgenet.c
+++ b/drivers/net/bcmgenet.c
@@ -526,8 +526,6 @@ static int bcmgenet_phy_init(struct bcmgenet_eth_priv *priv, void *dev)
        }
        phydev->advertising = phydev->supported;
 
-       phy_connect_dev(phydev, dev);
-
        priv->phydev = phydev;
        phy_config(priv->phydev);
 

diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 5943a5e3f0a81cb88e8d1bfd2b6b1ff97eebb488..906a8ec5d0948c274be31c6bb4cfe45966d6b732 100644 (file)
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -391,8 +391,6 @@ static int sun8i_phy_init(struct emac_eth_dev *priv, void *dev)
        if (!phydev)
                return -ENODEV;
 
-       phy_connect_dev(phydev, dev);
-
        priv->phydev = phydev;
        phy_config(priv->phydev);