]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
pinctrl: stmfx: update the result type of dm_i2c_reg_read
authorPatrick Delaunay <patrick.delaunay@st.com>
Tue, 28 Jan 2020 09:44:14 +0000 (10:44 +0100)
committerPatrick Delaunay <patrick.delaunay@st.com>
Thu, 13 Feb 2020 17:47:00 +0000 (18:47 +0100)
Use int as result of dm_i2c_reg_read to avoid warning with
W=1 (warning: comparison is always false due to limited range
of data type [-Wtype-limits])

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
drivers/pinctrl/pinctrl-stmfx.c

index c8e61e2918d4d493e3894aec257e036f0fd023d9..b0e43ae0a16e53f3d29a7b26c6b7f929eafdc678 100644 (file)
@@ -352,11 +352,12 @@ static int stmfx_chip_init(struct udevice *dev)
        int ret;
        struct dm_i2c_chip *chip = dev_get_parent_platdata(dev);
 
-       id = dm_i2c_reg_read(dev, STMFX_REG_CHIP_ID);
-       if (id < 0) {
-               dev_err(dev, "error reading chip id: %d\n", id);
+       ret = dm_i2c_reg_read(dev, STMFX_REG_CHIP_ID);
+       if (ret < 0) {
+               dev_err(dev, "error reading chip id: %d\n", ret);
                return ret;
        }
+       id = (u8)ret;
        /*
         * Check that ID is the complement of the I2C address:
         * STMFX I2C address follows the 7-bit format (MSB), that's why