]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
fs: remove distractive message in fs_read()
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Mon, 1 Jan 2018 20:15:37 +0000 (21:15 +0100)
committerTom Rini <trini@konsulko.com>
Fri, 19 Jan 2018 20:49:28 +0000 (15:49 -0500)
The message
"** %s shorter than offset + len **\n"
may be interesting when debugging but it does not indicate an
error.

So we should not write it if we are not in debug mode.

Fixes: 7a3e70cfd88c fs/fs.c: read up to EOF when len would read past EOF
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
fs/fs.c

diff --git a/fs/fs.c b/fs/fs.c
index 9c4d67faf82324c44d051ab4c14ed8734784b0a1..6155cb1daf34352c95f3d5270e5cf7b8d7b0e32f 100644 (file)
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -407,7 +407,7 @@ int fs_read(const char *filename, ulong addr, loff_t offset, loff_t len,
 
        /* If we requested a specific number of bytes, check we got it */
        if (ret == 0 && len && *actread != len)
-               printf("** %s shorter than offset + len **\n", filename);
+               debug("** %s shorter than offset + len **\n", filename);
        fs_close();
 
        return ret;