]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
board: verdin-am62: improve comment on usb phy core voltage
authorMax Krummenacher <max.krummenacher@toradex.com>
Wed, 17 Jan 2024 10:16:46 +0000 (11:16 +0100)
committerTom Rini <trini@konsulko.com>
Wed, 24 Jan 2024 16:12:11 +0000 (11:12 -0500)
TI recommends to clear the bit independent of the used voltage.
So the comment which claims to do it due to the core voltage
at 0.85V is bogus.

See https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1252724/am625-usb-phy-core-voltage-selection-and-vdda_core_usb-mismatch

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
board/toradex/verdin-am62/verdin-am62.c

index 2718263eb19b4cbbf513a84fc15e537b357f63db..e948fc16ba9946f22d416e19fb1e5493ced0d618 100644 (file)
@@ -102,12 +102,13 @@ void spl_board_init(void)
 {
        u32 val;
 
-       /* Set USB0 PHY core voltage to 0.85V */
+       /* Clear USB0_PHY_CTRL_CORE_VOLTAGE */
+       /* TI recommends to clear the bit independent of VDDA_CORE_USB */
        val = readl(CTRLMMR_USB0_PHY_CTRL);
        val &= ~(CORE_VOLTAGE);
        writel(val, CTRLMMR_USB0_PHY_CTRL);
 
-       /* Set USB1 PHY core voltage to 0.85V */
+       /* Clear USB1_PHY_CTRL_CORE_VOLTAGE */
        val = readl(CTRLMMR_USB1_PHY_CTRL);
        val &= ~(CORE_VOLTAGE);
        writel(val, CTRLMMR_USB1_PHY_CTRL);