]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
remoteproc: stm32: update error management in stm32_copro_start
authorPatrick Delaunay <patrick.delaunay@st.com>
Thu, 15 Oct 2020 13:01:13 +0000 (15:01 +0200)
committerPatrick Delaunay <patrick.delaunay@st.com>
Wed, 25 Nov 2020 10:32:31 +0000 (11:32 +0100)
The coprocessor is running as soon as the hold boot is de-asserted.

So indicate this running state and save the resource table even
if the protective assert, to avoid autonomous reboot, is failed.

This error case should never occurs.

Cc: Fabien DESSENNE <fabien.dessenne@st.com>
Cc: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
drivers/remoteproc/stm32_copro.c

index da678cb32933d6e07b5cd14f42b9db982245ce5e..dc87cb794e4fdd61b75a869ab7bbded63f53123f 100644 (file)
@@ -139,19 +139,18 @@ static int stm32_copro_start(struct udevice *dev)
 
        /*
         * Once copro running, reset hold boot flag to avoid copro
-        * rebooting autonomously
+        * rebooting autonomously (error should never occur)
         */
        ret = reset_assert(&priv->hold_boot);
        if (ret)
                dev_err(dev, "Unable to assert hold boot (ret=%d)\n", ret);
 
-       writel(ret ? TAMP_COPRO_STATE_OFF : TAMP_COPRO_STATE_CRUN,
-              TAMP_COPRO_STATE);
-       if (!ret)
-               /* Store rsc_address in bkp register */
-               writel(priv->rsc_table_addr, TAMP_COPRO_RSC_TBL_ADDRESS);
+       /* indicates that copro is running */
+       writel(TAMP_COPRO_STATE_CRUN, TAMP_COPRO_STATE);
+       /* Store rsc_address in bkp register */
+       writel(priv->rsc_table_addr, TAMP_COPRO_RSC_TBL_ADDRESS);
 
-       return ret;
+       return 0;
 }
 
 /**