drivers: net: pfe_eth: undefined return value

Do not use random value from stack as return value of pfe_phy_write().

Indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>

diff --git a/drivers/net/pfe_eth/pfe_mdio.c b/drivers/net/pfe_eth/pfe_mdio.c
index 2dde9e7ac87d315b7f594328649a5c8a3be4575e..62309670fabf3591d3babb20ae3a875b7532cf36 100644 (file)
--- a/drivers/net/pfe_eth/pfe_mdio.c
+++ b/drivers/net/pfe_eth/pfe_mdio.c
@@ -110,7 +110,6 @@ static int pfe_phy_write(struct mii_dev *bus, int phy_addr, int dev_addr,
        u32 phy;
        u32 reg_data;
        int timeout = MDIO_TIMEOUT;
-       int val;
 
        if (dev_addr == MDIO_DEVAD_NONE) {
                reg = ((reg_addr & EMAC_MII_DATA_RA_MASK) <<
@@ -150,7 +149,7 @@ static int pfe_phy_write(struct mii_dev *bus, int phy_addr, int dev_addr,
        debug("%s: phy: %02x reg:%02x val:%#x\n", __func__, phy_addr,
              reg_addr, data);
 
-       return val;
+       return 0;
 }
 
 static void pfe_configure_serdes(struct pfe_eth_dev *priv)