]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
x86: call32: Append appropriate suffixes
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 28 Jul 2020 09:56:26 +0000 (12:56 +0300)
committerBin Meng <bmeng.cn@gmail.com>
Mon, 3 Aug 2020 02:46:56 +0000 (10:46 +0800)
Assembler is not happy:

arch/x86/cpu/call32.S: Assembler messages:
arch/x86/cpu/call32.S:36: Warning: no instruction mnemonic suffix given and no register operands; using default for `retf'

Fix this by adding appropriate suffixes to the assembler commands.

Fixes: 6f92ed8f1abf ("x86: Add a way to call 32-bit code from 64-bit mode")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
arch/x86/cpu/call32.S

index e185b9a42b034cedeefa0376d44e4e4d1b2b69d6..e641e781c04c52ef405947a63808530458ff2def 100644 (file)
@@ -32,8 +32,7 @@ cpu_call32:
        push    %rdi    /* 32-bit code segment */
        lea     compat(%rip), %rax
        push    %rax
-       .byte   0x48    /* REX prefix to force 64-bit far return */
-       retf
+       retfq
 .code32
 compat:
        /*
@@ -60,4 +59,4 @@ compat:
        /* Jump to the required target */
        pushl   %edi    /* 32-bit code segment */
        pushl   %esi    /* 32-bit target address */
-       retf
+       retfl