]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
test: fix a couple NULL vs IS_ERR() checks
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 31 Jul 2023 14:08:41 +0000 (17:08 +0300)
committerTom Rini <trini@konsulko.com>
Tue, 8 Aug 2023 21:41:52 +0000 (17:41 -0400)
The x509_cert_parse() and pkcs7_parse_message() functions return error
pointers.  They don't return NULL.  Update the checks accordingly.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
test/lib/asn1.c

index 8661fdd30687e0d4fb226a24f33e338abab5d279..a66cdd77df0ad80f3acf66fec1a76ccc2c138f82 100644 (file)
@@ -120,7 +120,7 @@ static int lib_asn1_x509(struct unit_test_state *uts)
 
        cert = x509_cert_parse(cert_data, cert_data_len);
 
-       ut_assertf(cert != NULL, "decoding failed\n");
+       ut_assertf(!IS_ERR(cert), "decoding failed\n");
        ut_assertf(!strcmp(cert->subject, "Linaro: Tester"),
                   "subject doesn't match\n");
        ut_assertf(!strcmp(cert->issuer, "Linaro: Tester"),
@@ -313,7 +313,7 @@ static int lib_asn1_pkcs7(struct unit_test_state *uts)
 
        pkcs7 = pkcs7_parse_message(image_pk7, image_pk7_len);
 
-       ut_assertf(pkcs7 != NULL, "decoding failed\n");
+       ut_assertf(!IS_ERR(pkcs7), "decoding failed\n");
        ut_assertf(pkcs7->data_len == 104, "signature size doesn't match\n");
        ut_assertf(pkcs7->signed_infos != NULL, "sign-info doesn't exist\n");
        ut_assertf(pkcs7->signed_infos->msgdigest_len == 32,