]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
test: fix launch_efi()
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Thu, 20 Apr 2023 17:49:47 +0000 (19:49 +0200)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 21 Apr 2023 06:50:35 +0000 (08:50 +0200)
We cannot use old_dtb in the finally block if it has not been assigned
before the try block.

test/py/tests/test_efi_fit.py:458:30:
E0601: Using variable 'old_dtb' before assignment (used-before-assignment)

Fixes: 8391f955494e ("test/py: Create a test for launching UEFI binaries from FIT images")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
test/py/tests/test_efi_fit.py

index 92d071f783959458c74d6e7774cb25ca7c909189..7b7c98fb04caa0015977b3e16e4aacc3bc7b5363 100644 (file)
@@ -433,11 +433,13 @@ def test_efi_fit_launch(u_boot_console):
     sys_arch = cons.config.buildconfig.get('config_sys_arch', '"sandbox"')[1:-1]
     is_sandbox = sys_arch == 'sandbox'
 
+    if is_sandbox:
+        old_dtb = cons.config.dtb
+
     try:
         if is_sandbox:
             # Use our own device tree file, will be restored afterwards.
             control_dtb = make_dtb('internal', False)
-            old_dtb = cons.config.dtb
             cons.config.dtb = control_dtb
 
         # Run tests