]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
efi_loader: fix efi_ecpt_register()
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 10 Feb 2023 08:19:41 +0000 (09:19 +0100)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 10 Feb 2023 12:05:40 +0000 (13:05 +0100)
num_entries should be unsigned to avoid warnings. As the target field is
u16 we should use this type.

    lib/efi_loader/efi_conformance.c: In function ‘efi_ecpt_register’:
    lib/efi_loader/efi_conformance.c:30:33: warning:
    conversion to ‘long unsigned int’ from ‘int’ may change
    the sign of the result [-Wsign-conversion]
       30 |         ecpt_size = num_entries * sizeof(efi_guid_t)
          |                                 ^
    lib/efi_loader/efi_conformance.c:46:36: warning:
    conversion from ‘int’ to ‘u16’ {aka ‘short unsigned int’}
    may change value [-Wconversion]
       46 |         ecpt->number_of_profiles = num_entries;
          |                                    ^~~~~~~~~~~

Fixes: 6b92c1735205 ("efi: Create ECPT table")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
lib/efi_loader/efi_conformance.c

index 3036d46349a3ad9b9a8e7787dfc4bea31e7fd7cf..0ca26f57a7f2323f23cfd9747d4bf19df630a44d 100644 (file)
@@ -22,7 +22,7 @@ static const efi_guid_t efi_ebbr_2_1_guid =
  */
 efi_status_t efi_ecpt_register(void)
 {
-       int num_entries = 0;
+       u16 num_entries = 0;
        struct efi_conformance_profiles_table *ecpt;
        efi_status_t ret;
        size_t ecpt_size;