net: lwip: fix dhcp_loop()

The local variables ipstr, maskstr and gwstr in static function
dhcp_loop() cannot be pointers to read-only data, since they may be
written to in case the device index is > 0. Therefore make them char
arrays allocated on the stack.

Reported-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

diff --git a/net/lwip/dhcp.c b/net/lwip/dhcp.c
index 23b56226921d4a96b30daf38eaaa918b05432751..bfc72ca6c5795ce30622114e117723c1cfd16c52 100644 (file)
--- a/net/lwip/dhcp.c
+++ b/net/lwip/dhcp.c
@@ -27,9 +27,9 @@ static void call_lwip_dhcp_fine_tmr(void *ctx)
 
 static int dhcp_loop(struct udevice *udev)
 {
-       char *ipstr = "ipaddr\0\0";
-       char *maskstr = "netmask\0\0";
-       char *gwstr = "gatewayip\0\0";
+       char ipstr[] = "ipaddr\0\0";
+       char maskstr[] = "netmask\0\0";
+       char gwstr[] = "gatewayip\0\0";
        unsigned long start;
        struct netif *netif;
        struct dhcp *dhcp;