]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
phy: phy-imx8mq-usb: Remove .exit operation
authorFabio Estevam <festevam@denx.de>
Thu, 19 Oct 2023 12:36:09 +0000 (09:36 -0300)
committerFabio Estevam <festevam@gmail.com>
Wed, 13 Dec 2023 12:52:53 +0000 (09:52 -0300)
Currently, when running "ums 0 mmc 2" and breaking it via
CTRL + C, the following message is seen:

u-boot=> ums 0 mmc 1
UMS: LUN 0, dev mmc 1, hwpart 0, sector 0x0, count 0x1dacc00
CTRL+C - Operation aborted
clk usb_phy_root_clk already disabled

The USB PHY clock is disabled twice: first it gets disabled
inside imx8mq_usb_phy_power_off(), then it is disabled again
inside imx8mq_usb_phy_exit().

Let the USB PHY clock be disabled only once inside
imx8mq_usb_phy_power_off() by removing the .exit operation.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Marek Vasut <marex@denx.de>
drivers/phy/phy-imx8mq-usb.c

index b660eadecf1ca0057ceeb80de030330cd6df4232..e5e96e77a681b4f347262ff650201094a3f95925 100644 (file)
@@ -231,16 +231,10 @@ static int imx8mq_usb_phy_power_off(struct phy *usb_phy)
        return 0;
 }
 
-static int imx8mq_usb_phy_exit(struct phy *usb_phy)
-{
-       return imx8mq_usb_phy_power_off(usb_phy);
-}
-
 struct phy_ops imx8mq_usb_phy_ops = {
        .init = imx8mpq_usb_phy_init,
        .power_on = imx8mq_usb_phy_power_on,
        .power_off = imx8mq_usb_phy_power_off,
-       .exit = imx8mq_usb_phy_exit,
 };
 
 int imx8mq_usb_phy_probe(struct udevice *dev)