]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
tools: image-host: fix wrong return value
authorMing Liu <liu.ming50@gmail.com>
Mon, 31 May 2021 07:04:51 +0000 (09:04 +0200)
committerTom Rini <trini@konsulko.com>
Wed, 14 Jul 2021 20:57:35 +0000 (16:57 -0400)
The return value '-ENOSPC' of fit_set_timestamp function does not match
the caller fit_image_write_sig's expection which is '-FDT_ERR_NOSPACE'.

Fix it by not calling fit_set_timestamp, but call fdt_setprop instead.

This fixes a following mkimage error:
| Can't write signature for 'signature@1' signature node in
| 'conf@imx6ull-colibri-wifi-eval-v3.dtb' conf node: <unknown error>
| mkimage Can't add hashes to FIT blob: -1

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Tested-by: Igor Opaniuk <igor.opaniuk@foundries.io>
tools/image-host.c

index 270d36fe45165e7e99847a45a48db2df75f7d5cb..73095461a79604afb7162bf85ad96a7d0166f473 100644 (file)
@@ -132,8 +132,10 @@ static int fit_image_write_sig(void *fit, int noffset, uint8_t *value,
        if (!ret) {
                time_t timestamp = imagetool_get_source_date(cmdname,
                                                             time(NULL));
+               uint32_t t = cpu_to_uimage(timestamp);
 
-               ret = fit_set_timestamp(fit, noffset, timestamp);
+               ret = fdt_setprop(fit, noffset, FIT_TIMESTAMP_PROP, &t,
+                       sizeof(uint32_t));
        }
        if (region_prop && !ret) {
                uint32_t strdata[2];