]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
imx: Ensure CAAM clock is enabled prior getting out_jr_size
authorBreno Lima <breno.lima@nxp.com>
Thu, 25 Mar 2021 09:30:04 +0000 (17:30 +0800)
committerStefano Babic <sbabic@denx.de>
Thu, 8 Apr 2021 07:18:29 +0000 (09:18 +0200)
Prior calling sec_in32() we have to ensure CAAM clock is enabled, the
function sec_in32() is reading CAAM registers and if CAAM clock is disabled
the system will hang.

Signed-off-by: Breno Lima <breno.lima@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
arch/arm/mach-imx/cmd_dek.c
arch/arm/mach-imx/cmd_mfgprot.c

index 5bf92cbecfb4ca023fa14848cfb78d602caa9cc2..9a965576c726949bee8668ae78fbdd4f571e3d73 100644 (file)
@@ -28,12 +28,12 @@ static int blob_encap_dek(const u8 *src, u8 *dst, u32 len)
        int ret = 0;
        u32 jr_size = 4;
 
+       hab_caam_clock_enable(1);
+
        u32 out_jr_size = sec_in32(CONFIG_SYS_FSL_JR0_ADDR +
                                   FSL_CAAM_ORSR_JRa_OFFSET);
-       if (out_jr_size != jr_size) {
-               hab_caam_clock_enable(1);
+       if (out_jr_size != jr_size)
                sec_init();
-       }
 
        if (!((len == 128) | (len == 192) | (len == 256))) {
                debug("Invalid DEK size. Valid sizes are 128, 192 and 256b\n");
index 6e567027c0564347159280cd100917e0a8ecef8b..dd506a16e80ceef5bdb789fed77c06da2b6854ea 100644 (file)
@@ -42,13 +42,14 @@ static int do_mfgprot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 
        /* Enable HAB clock */
        u32 jr_size = 4;
+
+       hab_caam_clock_enable(1);
+
        u32 out_jr_size = sec_in32(CONFIG_SYS_FSL_JR0_ADDR +
                                   FSL_CAAM_ORSR_JRa_OFFSET);
 
-       if (out_jr_size != jr_size) {
-               hab_caam_clock_enable(1);
+       if (out_jr_size != jr_size)
                sec_init();
-       }
 
        if (strcmp(sel, pubk) == 0) {
                dst_ptr = malloc_cache_aligned(FSL_CAAM_MP_PUBK_BYTES);