]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
serial: pl01x: Add error value checking
authorMichal Simek <michal.simek@xilinx.com>
Tue, 13 Oct 2020 13:00:24 +0000 (15:00 +0200)
committerMichal Simek <michal.simek@xilinx.com>
Tue, 27 Oct 2020 07:13:32 +0000 (08:13 +0100)
There also a need to check return values to make sure that clocks were
enabled and setup properly.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/serial/serial_pl01x.c

index 2772c25f1d2d4f3706029c661fff9a3c8bb1f21e..d9e35c6a2b47e12ca2b9d899c4b8690a2e4a10b7 100644 (file)
@@ -19,6 +19,7 @@
 #include <watchdog.h>
 #include <asm/io.h>
 #include <serial.h>
+#include <dm/device_compat.h>
 #include <dm/platform_data/serial_pl01x.h>
 #include <linux/compiler.h>
 #include "serial_pl01x_internal.h"
@@ -362,8 +363,18 @@ int pl01x_serial_ofdata_to_platdata(struct udevice *dev)
        plat->clock = dev_read_u32_default(dev, "clock", CONFIG_PL011_CLOCK);
        ret = clk_get_by_index(dev, 0, &clk);
        if (!ret) {
-               clk_enable(&clk);
+               ret = clk_enable(&clk);
+               if (ret && ret != -ENOSYS) {
+                       dev_err(dev, "failed to enable clock\n");
+                       return ret;
+               }
+
                plat->clock = clk_get_rate(&clk);
+               if (IS_ERR_VALUE(plat->clock)) {
+                       dev_err(dev, "failed to get rate\n");
+                       return plat->clock;
+               }
+               debug("%s: CLK %d\n", __func__, plat->clock);
        }
        plat->type = dev_get_driver_data(dev);
        plat->skip_init = dev_read_bool(dev, "skip-init");