]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
pinctrl: single: fix the loop counter variable type
authorDario Binacchi <dariobin@libero.it>
Sun, 11 Apr 2021 07:39:40 +0000 (09:39 +0200)
committerLokesh Vutla <lokeshvutla@ti.com>
Mon, 12 Apr 2021 05:47:15 +0000 (11:17 +0530)
The 'n' variable is used as a loop counter, not as a physical address,
and is used in a comparison with an int. So it makes sense to change
its type from phys_addr_t to int.

Signed-off-by: Dario Binacchi <dariobin@libero.it>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
drivers/pinctrl/pinctrl-single.c

index c9a6c272bffbd860fe9b35d6afd6819c1d32b9a1..49ed15211d4cccdba2f22e829a70325452641b30 100644 (file)
@@ -75,8 +75,8 @@ static int single_configure_pins(struct udevice *dev,
                                 int size)
 {
        struct single_pdata *pdata = dev_get_plat(dev);
-       int count = size / sizeof(struct single_fdt_pin_cfg);
-       phys_addr_t n, reg;
+       int n, count = size / sizeof(struct single_fdt_pin_cfg);
+       phys_addr_t reg;
        u32 val;
 
        for (n = 0; n < count; n++, pins++) {
@@ -109,8 +109,8 @@ static int single_configure_bits(struct udevice *dev,
                                 int size)
 {
        struct single_pdata *pdata = dev_get_plat(dev);
-       int count = size / sizeof(struct single_fdt_bits_cfg);
-       phys_addr_t n, reg;
+       int n, count = size / sizeof(struct single_fdt_bits_cfg);
+       phys_addr_t reg;
        u32 val, mask;
 
        for (n = 0; n < count; n++, pins++) {