]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
riscv: andes_plic: Fix riscv_get_ipi() mask
authorBin Meng <bmeng.cn@gmail.com>
Tue, 15 Jun 2021 05:45:57 +0000 (13:45 +0800)
committerLeo Yu-Chi Liang <ycliang@andestech.com>
Thu, 17 Jun 2021 01:39:46 +0000 (09:39 +0800)
Current logic in riscv_get_ipi() for Andes PLICSW does not look
correct. The mask to test IPI pending bits for a hart should be
left shifted by (8 * gd->arch.boot_hart), just the same as what
is done in riscv_send_ipi().

Fixes: 8b3e97badf97 ("riscv: add functions for reading the IPI status")
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Rick Chen <rick@andestech.com>
Tested-by: Rick Chen <rick@andestech.com>
arch/riscv/lib/andes_plic.c

index 221a5fe324e2ab1449e45277c5262844a9299920..5e113ee8c94ced7929f2877d03bac24ebd1cd11d 100644 (file)
@@ -105,9 +105,11 @@ int riscv_clear_ipi(int hart)
 
 int riscv_get_ipi(int hart, int *pending)
 {
+       unsigned int ipi = (SEND_IPI_TO_HART(hart) << (8 * gd->arch.boot_hart));
+
        *pending = readl((void __iomem *)PENDING_REG(gd->arch.plic,
                                                     gd->arch.boot_hart));
-       *pending = !!(*pending & SEND_IPI_TO_HART(hart));
+       *pending = !!(*pending & ipi);
 
        return 0;
 }