]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
i2c: muxes: pca954x: clarify enable field
authorLuca Ceresoli <luca@lucaceresoli.net>
Tue, 9 Apr 2019 06:57:42 +0000 (08:57 +0200)
committerHeiko Schocher <hs@denx.de>
Thu, 11 Apr 2019 13:21:33 +0000 (15:21 +0200)
The chip_desc.enable field is used only for muxes, not for switches.
Document it and remove the unused values.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Heiko Schocher <hs@denx.de>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Heiko Schocher<hs@denx.de>
drivers/i2c/muxes/pca954x.c

index bd4e9abe5f3c0ca6d913aed522e3dcc868ff6e25..5669753ce14d2c280ebfbbc4bc97f23278f8d6b7 100644 (file)
@@ -22,7 +22,7 @@ enum pca_type {
 };
 
 struct chip_desc {
-       u8 enable;
+       u8 enable; /* Enable mask in ctl register (used for muxes only) */
        enum muxtype {
                pca954x_ismux = 0,
                pca954x_isswi,
@@ -48,12 +48,10 @@ static const struct chip_desc chips[] = {
                .width = 8,
        },
        [PCA9548] = {
-               .enable = 0x8,
                .muxtype = pca954x_isswi,
                .width = 8,
        },
        [PCA9646] = {
-               .enable = 0x0,
                .muxtype = pca954x_isswi,
                .width = 4,
        },