]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
efi_loader: fix struct efi_input_key
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 10 Feb 2023 07:13:23 +0000 (08:13 +0100)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 10 Feb 2023 12:05:40 +0000 (13:05 +0100)
The UEFI specification defines filed UnicodeChar as CHAR16. We use
u16 for CHAR16 throughout our code. The change fixes the following errors:

    lib/efi_loader/initrddump.c: In function ‘efi_input’:
    lib/efi_loader/initrddump.c:218:38: warning:
    comparison is always false due to limited range of data type
    [-Wtype-limits]
      218 | if (key.unicode_char >= 0xD800 && key.unicode_char <= 0xDBFF)
          |                      ^~
    lib/efi_loader/initrddump.c:218:68: warning:
    comparison is always true due to limited range of data type
    [-Wtype-limits]
      218 | if (key.unicode_char >= 0xD800 && key.unicode_char <= 0xDBFF)
          |                                                    ^~

Fixes: 867a6ac86dd8 ("efi: Add start-up library code")
Reported-by: Marek Vasut <marex@denx.de>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
include/efi_api.h

index 9bd70b0f18ceb782484dfeace65f21b6dc32b472..e1cdaf52479696ec8324ab4c39904b1ec357d92b 100644 (file)
@@ -817,7 +817,7 @@ struct efi_simple_text_output_protocol {
 
 struct efi_input_key {
        u16 scan_code;
-       s16 unicode_char;
+       u16 unicode_char;
 };
 
 #define EFI_SHIFT_STATE_INVALID                0x00000000