]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
buildman: Just display a single line for missing maintainers
authorSimon Glass <sjg@chromium.org>
Wed, 19 Jul 2023 23:48:24 +0000 (17:48 -0600)
committerSimon Glass <sjg@chromium.org>
Mon, 24 Jul 2023 15:34:10 +0000 (09:34 -0600)
At present we get multiple lines of output when a board has no MAINTAINERS
entry:

   WARNING: no status info for 'bananapi-m2-pro'
   WARNING: no maintainers for 'bananapi-m2-pro'

Suppress the 'status' one since it is implied by the other.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/buildman/boards.py
tools/buildman/func_test.py

index bf396574e2277d9edcbbf0253b1f7f3de4093b75..422f3476b01173adb42a2294c3bf281e9299f503 100644 (file)
@@ -772,8 +772,12 @@ class Boards:
 
         for i, params in enumerate(params_list):
             target = params['target']
-            params['status'] = database.get_status(target)
-            params['maintainers'] = database.get_maintainers(target)
+            maintainers = database.get_maintainers(target)
+            params['maintainers'] = maintainers
+            if maintainers:
+                params['status'] = database.get_status(target)
+            else:
+                params['status'] = '-'
             params_list[i] = params
         return database.warnings
 
index 164dd7c620a2cef9cff07f35cacdd5014f3611c3..149551e6f33cc1101bd8ec076a8407e75d64ed53 100644 (file)
@@ -920,7 +920,6 @@ Active  aarch64     armv8 - armltd total_compute board2
         self.assertEquals(2, len(params_list))
         self.assertEquals(
             ['WARNING: orphaned defconfig in boards/board0/MAINTAINERS ending at line 4',
-             "WARNING: no status info for 'board0'",
              "WARNING: no maintainers for 'board0'"], warnings)
 
         # Remove the maintainer line (M:) from a file (this should be fine)