x86: pinctrl: Add a way to get the pinctrl reg address

At present we can query the offset of a pinctrl register within the p2sb.
For ACPI we need to get the actual address of the register. Add a function
to handle this and rename the old one to more accurately reflect its
purpose.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>

diff --git a/arch/x86/include/asm/intel_pinctrl.h b/arch/x86/include/asm/intel_pinctrl.h
index e2524b089d4c67e4302f6dd60af9a1399e6b4c42..b5564b9ee1190a75145bdf69567059662ee33710 100644 (file)
--- a/arch/x86/include/asm/intel_pinctrl.h
+++ b/arch/x86/include/asm/intel_pinctrl.h
@@ -263,11 +263,23 @@ int pinctrl_read_pads(struct udevice *dev, ofnode node, const char *prop,
 int pinctrl_count_pads(struct udevice *dev, u32 *pads, int size);
 
 /**
- * intel_pinctrl_get_config_reg_addr() - Get address of the pin config registers
+ * intel_pinctrl_get_config_reg_offset() - Get offset of pin config registers
  *
+ * This works out the register offset of a pin within the p2sb region.
+ *
+ * @dev: Pinctrl device
+ * @offset: GPIO offset within this device
+ * @return register offset of first register within the GPIO p2sb region
+ */
+u32 intel_pinctrl_get_config_reg_offset(struct udevice *dev, uint offset);
+
+/**
+ * intel_pinctrl_get_config_reg_addr() - Get address of pin config registers
+ *
+ * This works out the absolute address of the registers for a pin
  * @dev: Pinctrl device
  * @offset: GPIO offset within this device
- * @return register offset within the GPIO p2sb region
+ * @return register address of first register within the GPIO p2sb region
  */
 u32 intel_pinctrl_get_config_reg_addr(struct udevice *dev, uint offset);
 

diff --git a/drivers/gpio/intel_gpio.c b/drivers/gpio/intel_gpio.c
index 711fea1b587679fd35865ba998e897c0edb3da84..b4d5be97dad72c6881a0b0f97c87ebd2984134ee 100644 (file)
--- a/drivers/gpio/intel_gpio.c
+++ b/drivers/gpio/intel_gpio.c
@@ -24,7 +24,9 @@
 static int intel_gpio_direction_input(struct udevice *dev, uint offset)
 {
        struct udevice *pinctrl = dev_get_parent(dev);
-       uint config_offset = intel_pinctrl_get_config_reg_addr(pinctrl, offset);
+       uint config_offset;
+
+       config_offset = intel_pinctrl_get_config_reg_offset(pinctrl, offset);
 
        pcr_clrsetbits32(pinctrl, config_offset,
                         PAD_CFG0_MODE_MASK | PAD_CFG0_TX_STATE |
@@ -38,7 +40,9 @@ static int intel_gpio_direction_output(struct udevice *dev, uint offset,
                                       int value)
 {
        struct udevice *pinctrl = dev_get_parent(dev);
-       uint config_offset = intel_pinctrl_get_config_reg_addr(pinctrl, offset);
+       uint config_offset;
+
+       config_offset = intel_pinctrl_get_config_reg_offset(pinctrl, offset);
 
        pcr_clrsetbits32(pinctrl, config_offset,
                         PAD_CFG0_MODE_MASK | PAD_CFG0_RX_STATE |
@@ -68,10 +72,13 @@ static int intel_gpio_get_value(struct udevice *dev, uint offset)
        return 0;
 }
 
-static int intel_gpio_set_value(struct udevice *dev, unsigned offset, int value)
+static int intel_gpio_set_value(struct udevice *dev, unsigned int offset,
+                               int value)
 {
        struct udevice *pinctrl = dev_get_parent(dev);
-       uint config_offset = intel_pinctrl_get_config_reg_addr(pinctrl, offset);
+       uint config_offset;
+
+       config_offset = intel_pinctrl_get_config_reg_offset(pinctrl, offset);
 
        pcr_clrsetbits32(pinctrl, config_offset, PAD_CFG0_TX_STATE,
                         value ? PAD_CFG0_TX_STATE : 0);

diff --git a/drivers/misc/p2sb-uclass.c b/drivers/misc/p2sb-uclass.c
index 06b1e8d9ad7cf0643234be24b8971843f32c4fea..d5fe12ebd8d19a70d2f96d1c3f98318ccd6611ee 100644 (file)
--- a/drivers/misc/p2sb-uclass.c
+++ b/drivers/misc/p2sb-uclass.c
@@ -18,7 +18,7 @@
 
 #define PCR_COMMON_IOSF_1_0    1
 
-static void *_pcr_reg_address(struct udevice *dev, uint offset)
+void *pcr_reg_address(struct udevice *dev, uint offset)
 {
        struct p2sb_child_platdata *pplat = dev_get_parent_platdata(dev);
        struct udevice *p2sb = dev_get_parent(dev);
@@ -55,7 +55,7 @@ uint pcr_read32(struct udevice *dev, uint offset)
        /* Ensure the PCR offset is correctly aligned */
        assert(IS_ALIGNED(offset, sizeof(uint32_t)));
 
-       ptr = _pcr_reg_address(dev, offset);
+       ptr = pcr_reg_address(dev, offset);
        val = readl(ptr);
        unmap_sysmem(ptr);
 
@@ -67,7 +67,7 @@ uint pcr_read16(struct udevice *dev, uint offset)
        /* Ensure the PCR offset is correctly aligned */
        check_pcr_offset_align(offset, sizeof(uint16_t));
 
-       return readw(_pcr_reg_address(dev, offset));
+       return readw(pcr_reg_address(dev, offset));
 }
 
 uint pcr_read8(struct udevice *dev, uint offset)
@@ -75,7 +75,7 @@ uint pcr_read8(struct udevice *dev, uint offset)
        /* Ensure the PCR offset is correctly aligned */
        check_pcr_offset_align(offset, sizeof(uint8_t));
 
-       return readb(_pcr_reg_address(dev, offset));
+       return readb(pcr_reg_address(dev, offset));
 }
 
 /*
@@ -86,7 +86,7 @@ uint pcr_read8(struct udevice *dev, uint offset)
  */
 static void write_completion(struct udevice *dev, uint offset)
 {
-       readl(_pcr_reg_address(dev, ALIGN_DOWN(offset, sizeof(uint32_t))));
+       readl(pcr_reg_address(dev, ALIGN_DOWN(offset, sizeof(uint32_t))));
 }
 
 void pcr_write32(struct udevice *dev, uint offset, uint indata)
@@ -94,7 +94,7 @@ void pcr_write32(struct udevice *dev, uint offset, uint indata)
        /* Ensure the PCR offset is correctly aligned */
        assert(IS_ALIGNED(offset, sizeof(indata)));
 
-       writel(indata, _pcr_reg_address(dev, offset));
+       writel(indata, pcr_reg_address(dev, offset));
        /* Ensure the writes complete */
        write_completion(dev, offset);
 }
@@ -104,7 +104,7 @@ void pcr_write16(struct udevice *dev, uint offset, uint indata)
        /* Ensure the PCR offset is correctly aligned */
        check_pcr_offset_align(offset, sizeof(uint16_t));
 
-       writew(indata, _pcr_reg_address(dev, offset));
+       writew(indata, pcr_reg_address(dev, offset));
        /* Ensure the writes complete */
        write_completion(dev, offset);
 }
@@ -114,7 +114,7 @@ void pcr_write8(struct udevice *dev, uint offset, uint indata)
        /* Ensure the PCR offset is correctly aligned */
        check_pcr_offset_align(offset, sizeof(uint8_t));
 
-       writeb(indata, _pcr_reg_address(dev, offset));
+       writeb(indata, pcr_reg_address(dev, offset));
        /* Ensure the writes complete */
        write_completion(dev, offset);
 }

diff --git a/drivers/pinctrl/intel/pinctrl.c b/drivers/pinctrl/intel/pinctrl.c
index ba8206350eaef7202e343034641a1b9625a700bd..bf3989bf327635e4065b18ef8661832faeebad37 100644 (file)
--- a/drivers/pinctrl/intel/pinctrl.c
+++ b/drivers/pinctrl/intel/pinctrl.c
@@ -394,7 +394,7 @@ static int pinctrl_configure_pad(struct udevice *dev,
        return 0;
 }
 
-u32 intel_pinctrl_get_config_reg_addr(struct udevice *dev, uint offset)
+u32 intel_pinctrl_get_config_reg_offset(struct udevice *dev, uint offset)
 {
        struct intel_pinctrl_priv *priv = dev_get_priv(dev);
        const struct pad_community *comm = priv->comm;
@@ -407,9 +407,16 @@ u32 intel_pinctrl_get_config_reg_addr(struct udevice *dev, uint offset)
        return config_offset;
 }
 
+u32 intel_pinctrl_get_config_reg_addr(struct udevice *dev, uint offset)
+{
+       uint config_offset = intel_pinctrl_get_config_reg_offset(dev, offset);
+
+       return (u32)(ulong)pcr_reg_address(dev, config_offset);
+}
+
 u32 intel_pinctrl_get_config_reg(struct udevice *dev, uint offset)
 {
-       uint config_offset = intel_pinctrl_get_config_reg_addr(dev, offset);
+       uint config_offset = intel_pinctrl_get_config_reg_offset(dev, offset);
 
        return pcr_read32(dev, config_offset);
 }

diff --git a/include/p2sb.h b/include/p2sb.h
index 60c7f70773c0df8ab7a0c5aeb8a30c9a901d7f1d..74eb08b7ff8b69d21ffd29c408421199203e20af 100644 (file)
--- a/include/p2sb.h
+++ b/include/p2sb.h
@@ -132,4 +132,13 @@ int p2sb_set_port_id(struct udevice *dev, int portid);
  */
 int p2sb_get_port_id(struct udevice *dev);
 
+/**
+ * pcr_reg_address() Convert an offset in p2sb space to an absolute address
+ *
+ * @dev: Child device (whose parent is UCLASS_P2SB)
+ * @offset: Offset within that child's address space
+ * @return pointer to that offset within the child's address space
+ */
+void *pcr_reg_address(struct udevice *dev, uint offset);
+
 #endif