common: avb_verify: Fix never-occurring avb_free(ops_data)

Cppcheck (v1.85) reports w/o this patch:

[common/avb_verify.c:738] -> [common/avb_verify.c:741]: (warning) \
  Either the condition 'ops' is redundant or there is possible null \
  pointer dereference: ops.

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>

diff --git a/common/avb_verify.c b/common/avb_verify.c
index 0bc1c2369fac419372595a97462c14d052542a30..0234f9842216973db858be41a67bbdf4dbee8f19 100644 (file)
--- a/common/avb_verify.c
+++ b/common/avb_verify.c
@@ -766,7 +766,7 @@ void avb_ops_free(AvbOps *ops)
 {
        struct AvbOpsData *ops_data;
 
-       if (ops)
+       if (!ops)
                return;
 
        ops_data = ops->user_data;