]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
efi_selftest: tpl unit test, check return values
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Sun, 6 Jan 2019 15:44:16 +0000 (16:44 +0100)
committerAlexander Graf <agraf@suse.de>
Wed, 13 Feb 2019 08:40:05 +0000 (09:40 +0100)
For some API calls checks for the return values are missing.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
lib/efi_selftest/efi_selftest_tpl.c

index 97d256abe4f482fe236d4c032c4319aaea691242..70a355eae6baa2e08dcc6116429446f6ea174e9a 100644 (file)
@@ -151,7 +151,7 @@ static int execute(void)
                return EFI_ST_FAILURE;
        }
        ret = boottime->set_timer(event_notify, EFI_TIMER_STOP, 0);
-       if (index != 0) {
+       if (ret != EFI_SUCCESS) {
                efi_st_error("Could not cancel timer\n");
                return EFI_ST_FAILURE;
        }
@@ -164,7 +164,7 @@ static int execute(void)
        /* Set 10 ms timer */
        notification_count = 0;
        ret = boottime->set_timer(event_notify, EFI_TIMER_PERIODIC, 100000);
-       if (index != 0) {
+       if (ret != EFI_SUCCESS) {
                efi_st_error("Could not set timer\n");
                return EFI_ST_FAILURE;
        }