]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
test: cmd/hash: check return value of ut_check_console_line
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 16 Nov 2024 20:08:22 +0000 (21:08 +0100)
committerTom Rini <trini@konsulko.com>
Tue, 19 Nov 2024 01:10:56 +0000 (19:10 -0600)
ut_check_console_line() does include an assert.
Pass the result to ut_assertok().

Addresses-Coverity-ID:  514958 Error handling issues
Fixes: 7dfafcd65ef3 ("test: unit test for hash command")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
test/cmd/hash.c

index 2fcec9cadcd25a904d482ecdf236bbabc2d0c915..296dd762b31d028565b2cab19597904444fae9fb 100644 (file)
@@ -33,11 +33,13 @@ static int dm_test_cmd_hash_md5(struct unit_test_state *uts)
                        strstr(uts->actual_str, "md5 for "));
        ut_assert(strstr(uts->actual_str,
                         "d41d8cd98f00b204e9800998ecf8427e"));
-       ut_check_console_line(uts, "d41d8cd98f00b204e9800998ecf8427e");
+       ut_assertok(ut_check_console_line(uts,
+                                         "d41d8cd98f00b204e9800998ecf8427e"));
 
        if (!CONFIG_IS_ENABLED(HASH_VERIFY)) {
                ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0));
-               ut_check_console_line(uts, "hash - compute hash message digest");
+               ut_assertok(ut_check_console_line(
+                               uts, "hash - compute hash message digest"));
 
                return 0;
        }
@@ -77,12 +79,13 @@ static int dm_test_cmd_hash_sha256(struct unit_test_state *uts)
                        strstr(uts->actual_str, "sha256 for "));
        ut_assert(strstr(uts->actual_str,
                         "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"));
-       ut_check_console_line(uts,
-                             "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855");
+       ut_assertok(ut_check_console_line(
+                       uts, "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"));
 
        if (!CONFIG_IS_ENABLED(HASH_VERIFY)) {
                ut_assert(run_command("hash -v sha256 $loadaddr 0 foo", 0));
-               ut_check_console_line(uts, "hash - compute hash message digest");
+               ut_assertok(ut_check_console_line(
+                               uts, "hash - compute hash message digest"));
 
                return 0;
        }