]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
zynq: mtd: nand: remove superfluous if
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Sun, 27 Dec 2020 10:28:12 +0000 (11:28 +0100)
committerMichal Simek <michal.simek@xilinx.com>
Tue, 5 Jan 2021 10:54:53 +0000 (11:54 +0100)
This sort of code does not make much sense:

    if (ondie_ecc_enabled) {
        if (ondie_ecc_enabled) {

Remove the inner if.

The problem was indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/mtd/nand/raw/zynq_nand.c

index 92db2aa19c8602904d649d83ae9980c406db80f2..65817ea7f21cd6e8c7a31acf00c532cd353acfe0 100644 (file)
@@ -1206,12 +1206,10 @@ static int zynq_nand_probe(struct udevice *dev)
                nand_chip->options |= NAND_SUBPAGE_READ;
 
                /* On-Die ECC spare bytes offset 8 is used for ECC codes */
-               if (ondie_ecc_enabled) {
-                       nand_chip->ecc.layout = &ondie_nand_oob_64;
-                       /* Use the BBT pattern descriptors */
-                       nand_chip->bbt_td = &bbt_main_descr;
-                       nand_chip->bbt_md = &bbt_mirror_descr;
-               }
+               nand_chip->ecc.layout = &ondie_nand_oob_64;
+               /* Use the BBT pattern descriptors */
+               nand_chip->bbt_td = &bbt_main_descr;
+               nand_chip->bbt_md = &bbt_mirror_descr;
        } else {
                /* Hardware ECC generates 3 bytes ECC code for each 512 bytes */
                nand_chip->ecc.mode = NAND_ECC_HW;