]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
authorMichael Trimarchi <michael@amarulasolutions.com>
Wed, 20 Jun 2018 20:51:18 +0000 (22:51 +0200)
committerJagan Teki <jagan@amarulasolutions.com>
Mon, 25 Jun 2018 09:53:06 +0000 (15:23 +0530)
CS GPIO activation low/high is determinated by the device tree
so we don't need to take in accoung in cs_activate and cs_deactivate

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Jagan Teki <jagan@openedev.com>
drivers/spi/mxc_spi.c

index fcb214af20b2e7f4ff4209a69f1cb3626dcfc872..0dccc38b82d241a23874dea24ee1f17351522e9d 100644 (file)
@@ -60,7 +60,7 @@ static inline struct mxc_spi_slave *to_mxc_spi_slave(struct spi_slave *slave)
 static void mxc_spi_cs_activate(struct mxc_spi_slave *mxcs)
 {
        if (CONFIG_IS_ENABLED(DM_SPI)) {
-               dm_gpio_set_value(&mxcs->ss, mxcs->ss_pol);
+               dm_gpio_set_value(&mxcs->ss, 1);
        } else {
                if (mxcs->gpio > 0)
                        gpio_set_value(mxcs->gpio, mxcs->ss_pol);
@@ -70,7 +70,7 @@ static void mxc_spi_cs_activate(struct mxc_spi_slave *mxcs)
 static void mxc_spi_cs_deactivate(struct mxc_spi_slave *mxcs)
 {
        if (CONFIG_IS_ENABLED(DM_SPI)) {
-               dm_gpio_set_value(&mxcs->ss, !(mxcs->ss_pol));
+               dm_gpio_set_value(&mxcs->ss, 0);
        } else {
                if (mxcs->gpio > 0)
                        gpio_set_value(mxcs->gpio, !(mxcs->ss_pol));
@@ -508,7 +508,7 @@ static int mxc_spi_probe(struct udevice *bus)
        if (plat->base == FDT_ADDR_T_NONE)
                return -ENODEV;
 
-       ret = dm_gpio_set_value(&plat->ss, !(mxcs->ss_pol));
+       ret = dm_gpio_set_value(&plat->ss, 0);
        if (ret) {
                dev_err(bus, "Setting cs error\n");
                return ret;