]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
bootflow: Fix build error when BOOTMETH_CROS is disabled
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 21 Feb 2024 06:26:09 +0000 (09:26 +0300)
committerTom Rini <trini@konsulko.com>
Mon, 4 Mar 2024 15:25:47 +0000 (10:25 -0500)
The bootflow testing assumes that BOOTMETH_CROS is enabled but it
might not be which leads to a build error.

aarch64-linux-gnu-ld.bfd: test/boot/bootflow.o: in function `prep_mmc_bootdev':
test/boot/bootflow.c:549:(.text.prep_mmc_bootdev+0x1c8):
    undefined reference to `_u_boot_list_2_driver_2_bootmeth_cros'

Fixes: d08db02d2d3d ("bootstd: Add a test for bootmeth_cros")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
test/boot/bootflow.c

index fa54dde661c8b6b71ee7f6610c7df5ed023f33e5..4845b7121c845535caef2e83957ef8a9e71652f5 100644 (file)
@@ -544,7 +544,7 @@ static int prep_mmc_bootdev(struct unit_test_state *uts, const char *mmc_dev,
                                "bootmeth_script", 0, ofnode_null(), &dev));
 
        /* Enable the cros bootmeth if needed */
-       if (bind_cros) {
+       if (IS_ENABLED(CONFIG_BOOTMETH_CROS) && bind_cros) {
                ut_assertok(uclass_first_device_err(UCLASS_BOOTSTD, &bootstd));
                ut_assertok(device_bind(bootstd, DM_DRIVER_REF(bootmeth_cros),
                                        "cros", 0, ofnode_null(), &dev));