]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
arm64: a37xx: pinctrl: probe after binding
authorRobert Marko <robert.marko@sartura.hr>
Tue, 17 Jan 2023 14:08:15 +0000 (15:08 +0100)
committerSimon Glass <sjg@chromium.org>
Wed, 1 Mar 2023 18:22:27 +0000 (11:22 -0700)
Currently, pinctrl drivers are getting probed during post-bind, however
that is being reverted, and on A37XX pinctrl driver is the one that
registers the GPIO driver during the probe.

So, if the pinctrl driver doesn't get probed GPIO-s won't get registered
and thus they cannot be used.

This is a problem on the Methode eDPU as it just uses SB pins as GPIO-s
and without them being registered networking won't work as it only has
one SFP slot and the TX disable GPIO is on the SB controller.

So, lets just add a flag only to A37XX driver to probe after binding
in order for the GPIO driver to always get registered.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

index 25fbe39abd193eb0be65ad19c9ef88ebc3bf6ab5..1be6252227d3f4cc90dd060c25cfaf0bf12c8e61 100644 (file)
@@ -745,6 +745,19 @@ static int armada_37xx_pinctrl_probe(struct udevice *dev)
        return 0;
 }
 
+static int armada_37xx_pinctrl_bind(struct udevice *dev)
+{
+       /*
+        * Make sure that the pinctrl driver gets probed after binding
+        * as on A37XX the pinctrl driver is the one that is also
+        * registering the GPIO one during probe, so if its not probed
+        * GPIO-s are not registered as well.
+        */
+       dev_or_flags(dev, DM_FLAG_PROBE_AFTER_BIND);
+
+       return 0;
+}
+
 static const struct udevice_id armada_37xx_pinctrl_of_match[] = {
        {
                .compatible = "marvell,armada3710-sb-pinctrl",
@@ -762,6 +775,7 @@ U_BOOT_DRIVER(armada_37xx_pinctrl) = {
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(armada_37xx_pinctrl_of_match),
        .probe = armada_37xx_pinctrl_probe,
+       .bind = armada_37xx_pinctrl_bind,
        .priv_auto      = sizeof(struct armada_37xx_pinctrl),
        .ops = &armada_37xx_pinctrl_ops,
 };