]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
clk: fix clock tree dump to properly dump out every registered clock
authorTero Kristo <t-kristo@ti.com>
Fri, 11 Jun 2021 08:45:07 +0000 (11:45 +0300)
committerLokesh Vutla <lokeshvutla@ti.com>
Fri, 11 Jun 2021 11:04:52 +0000 (16:34 +0530)
Some clocks are not associated to a DM node, so just parsing the DM is not
enough. This is especially true for root clocks, which typically don't have
any parents. Instead, fetch every registered UCLASS_CLK instance, and dump
these out.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tero Kristo <kristo@kernel.org>
cmd/clk.c

index e3c3d2f9bb224a2871047a64c90c100afc8f5a4c..0245b97136043bcfe186707938df03d16cd5962d 100644 (file)
--- a/cmd/clk.c
+++ b/cmd/clk.c
@@ -18,11 +18,14 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
 {
        int i, is_last;
        struct udevice *child;
-       struct clk *clkp;
+       struct clk *clkp, *parent;
        u32 rate;
 
        clkp = dev_get_clk_ptr(dev);
        if (device_get_uclass_id(dev) == UCLASS_CLK && clkp) {
+               parent = clk_get_parent(clkp);
+               if (!IS_ERR(parent) && depth == -1)
+                       return;
                depth++;
                rate = clk_get_rate(clkp);
 
@@ -47,6 +50,9 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
        }
 
        list_for_each_entry(child, &dev->child_head, sibling_node) {
+               if (child == dev)
+                       continue;
+
                is_last = list_is_last(&child->sibling_node, &dev->child_head);
                show_clks(child, depth, (last_flag << 1) | is_last);
        }
@@ -54,14 +60,19 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
 
 int __weak soc_clk_dump(void)
 {
-       struct udevice *root;
+       struct udevice *dev;
+       struct uclass *uc;
+       int ret;
 
-       root = dm_root();
-       if (root) {
-               printf(" Rate               Usecnt      Name\n");
-               printf("------------------------------------------\n");
-               show_clks(root, -1, 0);
-       }
+       ret = uclass_get(UCLASS_CLK, &uc);
+       if (ret)
+               return ret;
+
+       printf(" Rate               Usecnt      Name\n");
+       printf("------------------------------------------\n");
+
+       uclass_foreach_dev(dev, uc)
+               show_clks(dev, -1, 0);
 
        return 0;
 }