]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
of: addr: Remove call to dev_count_cells() in of_get_address()
authorBin Meng <bmeng.cn@gmail.com>
Fri, 30 Apr 2021 13:16:59 +0000 (21:16 +0800)
committerSimon Glass <sjg@chromium.org>
Sat, 5 Jun 2021 13:35:34 +0000 (07:35 -0600)
In of_get_address(), there is:

  dev_count_cells(dev, &na, &ns);

followed by:

  bus->count_cells(dev, &na, &ns);

but no codes in between use na/ns, hence the first call is useless.
By dropping the first call, dev_count_cells() is now useless too.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/core/of_addr.c

index a3af48fd885416262af2971323cca9825363af2a..3fbc0a7afa6cf2a1b12abfa5c21dd07170a585b0 100644 (file)
@@ -118,11 +118,6 @@ static struct of_bus *of_match_bus(struct device_node *np)
        return NULL;
 }
 
-static void dev_count_cells(const struct device_node *np, int *nap, int *nsp)
-{
-       of_bus_default_count_cells(np, nap, nsp);
-}
-
 const __be32 *of_get_address(const struct device_node *dev, int index,
                             u64 *size, unsigned int *flags)
 {
@@ -136,7 +131,6 @@ const __be32 *of_get_address(const struct device_node *dev, int index,
        parent = of_get_parent(dev);
        if (parent == NULL)
                return NULL;
-       dev_count_cells(dev, &na, &ns);
        bus = of_match_bus(parent);
        bus->count_cells(dev, &na, &ns);
        of_node_put(parent);