]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
video: Avoid using #ifdef in video-uclass.c
authorSimon Glass <sjg@chromium.org>
Sat, 21 Dec 2019 01:10:37 +0000 (18:10 -0700)
committerAnatolij Gustschin <agust@denx.de>
Thu, 2 Jan 2020 15:25:25 +0000 (16:25 +0100)
This code does not really need to use #ifdef. We can use if() instead and
gain build coverage without impacting code size.

Change the #ifdefs to use IS_ENABLED(), etc., instead.

Signed-off-by: Simon Glass <sjg@chromium.org>
drivers/video/video-uclass.c

index 5ea7568fa4c8f1c0b70dbcd944675edc570e85ce..12057c8a5beaacb0acb96f63fb6bf7f623a33de1 100644 (file)
@@ -92,26 +92,24 @@ int video_clear(struct udevice *dev)
        struct video_priv *priv = dev_get_uclass_priv(dev);
 
        switch (priv->bpix) {
-#ifdef CONFIG_VIDEO_BPP16
-       case VIDEO_BPP16: {
-               u16 *ppix = priv->fb;
-               u16 *end = priv->fb + priv->fb_size;
-
-               while (ppix < end)
-                       *ppix++ = priv->colour_bg;
-               break;
-       }
-#endif
-#ifdef CONFIG_VIDEO_BPP32
-       case VIDEO_BPP32: {
-               u32 *ppix = priv->fb;
-               u32 *end = priv->fb + priv->fb_size;
-
-               while (ppix < end)
-                       *ppix++ = priv->colour_bg;
-               break;
-       }
-#endif
+       case VIDEO_BPP16:
+               if (IS_ENABLED(CONFIG_VIDEO_BPP16)) {
+                       u16 *ppix = priv->fb;
+                       u16 *end = priv->fb + priv->fb_size;
+
+                       while (ppix < end)
+                               *ppix++ = priv->colour_bg;
+                       break;
+               }
+       case VIDEO_BPP32:
+               if (IS_ENABLED(CONFIG_VIDEO_BPP32)) {
+                       u32 *ppix = priv->fb;
+                       u32 *end = priv->fb + priv->fb_size;
+
+                       while (ppix < end)
+                               *ppix++ = priv->colour_bg;
+                       break;
+               }
        default:
                memset(priv->fb, priv->colour_bg, priv->fb_size);
                break;
@@ -125,14 +123,14 @@ void video_set_default_colors(struct udevice *dev, bool invert)
        struct video_priv *priv = dev_get_uclass_priv(dev);
        int fore, back;
 
-#ifdef CONFIG_SYS_WHITE_ON_BLACK
-       /* White is used when switching to bold, use light gray here */
-       fore = VID_LIGHT_GRAY;
-       back = VID_BLACK;
-#else
-       fore = VID_BLACK;
-       back = VID_WHITE;
-#endif
+       if (CONFIG_IS_ENABLED(SYS_WHITE_ON_BLACK)) {
+               /* White is used when switching to bold, use light gray here */
+               fore = VID_LIGHT_GRAY;
+               back = VID_BLACK;
+       } else {
+               fore = VID_BLACK;
+               back = VID_WHITE;
+       }
        if (invert) {
                int temp;