]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
tools: kwbimage: Add support for dumping NAND_BLKSZ for v0 images
authorPali Rohár <pali@kernel.org>
Sun, 8 Jan 2023 15:22:34 +0000 (16:22 +0100)
committerStefan Roese <sr@denx.de>
Wed, 1 Mar 2023 05:39:17 +0000 (06:39 +0100)
In Dove functional specification, which use kwbimage v0, is also defined
nand block size field. So dump NAND_BLKSZ also for v0 images.

In Kirkwood functional specification, which also use kwbimage v0, this
field is not defined. So when it is zero and Kirkwood is detected, do not
dump it.

Fixes: f76ae2571fe0 ("tools: kwbimage: Add support for dumping extended and binary v0 headers")
Signed-off-by: Pali Rohár <pali@kernel.org>
tools/kwbimage.c

index 0c3b40d075e958287093e6d538f76b92b443c53e..eb99ac944d24073694764078776c459c15a2172b 100644 (file)
@@ -2185,7 +2185,7 @@ static int kwbimage_generate_config(void *ptr, struct image_tool_params *params)
        if (mhdr->blockid == IBR_HDR_NAND_ID)
                fprintf(f, "NAND_PAGE_SIZE 0x%x\n", (unsigned)le16_to_cpu(mhdr->nandpagesize));
 
-       if (version != 0 && mhdr->blockid == IBR_HDR_NAND_ID) {
+       if (mhdr->blockid == IBR_HDR_NAND_ID && (version != 0 || is_v0_ext || mhdr->nandblocksize != 0)) {
                if (mhdr->nandblocksize != 0) /* block size explicitly set in 64 kB unit */
                        fprintf(f, "NAND_BLKSZ 0x%x\n", (unsigned)mhdr->nandblocksize * 64*1024);
                else if (le16_to_cpu(mhdr->nandpagesize) > 512)