]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
x86: coreboot: Avoid a declaration after a label
authorSimon Glass <sjg@chromium.org>
Thu, 31 Aug 2023 17:20:53 +0000 (11:20 -0600)
committerBin Meng <bmeng@tinylab.org>
Thu, 21 Sep 2023 22:03:46 +0000 (06:03 +0800)
Declare the global_data pointer at the top of the file, to avoid an
error:

   arch/x86/include/asm/global_data.h:143:35: error: a label can
      only be part of a statement and a declaration is not a statement
   board/coreboot/coreboot/coreboot.c:60:2: note: in expansion of macro
      â€˜DECLARE_GLOBAL_DATA_PTR’

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
board/coreboot/coreboot/coreboot.c

index 3b90ae75386bf86da2893227b1a442f011495efb..db855c11ae65f959d5afb0e8b6391bff57c15900 100644 (file)
@@ -10,6 +10,8 @@
 #include <asm/cb_sysinfo.h>
 #include <asm/global_data.h>
 
+DECLARE_GLOBAL_DATA_PTR;
+
 int board_early_init_r(void)
 {
        /*
@@ -54,14 +56,12 @@ int show_board_info(void)
        return 0;
 
 fallback:
-#ifdef CONFIG_OF_CONTROL
-       DECLARE_GLOBAL_DATA_PTR;
-
-       model = fdt_getprop(gd->fdt_blob, 0, "model", NULL);
+       if (IS_ENABLED(CONFIG_OF_CONTROL)) {
+               model = fdt_getprop(gd->fdt_blob, 0, "model", NULL);
 
-       if (model)
-               printf("Model: %s\n", model);
-#endif
+               if (model)
+                       printf("Model: %s\n", model);
+       }
 
        return checkboard();
 }