dm: core: Mark device as active before calling its probe() method

At present the device is not active when the probe() method is called. But
some probe() methods want to set up the device and this can involve
accessing it through normal methods. For example a PCI bus may wish to
set up its PCI parameters using calls to pci_hose_write_config_dword() and
similar.

At present this does not work because every such call within the probe()
method sees that the device is not active and attempts to probe it.

Already we mark the device as probed before calling the uclass post_probe()
method. This is a subtle change but I believe the new approach is better.
Since the scope of the change is only the probe() method and all its callees
it should still be within the control of the board author.

Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/drivers/core/device.c b/drivers/core/device.c
index 92e8a57bf69b1bedc608cb9f5ace3585fe99777b..6bd4b26623d3716930cde9726d3300db374d25dc 100644 (file)
--- a/drivers/core/device.c
+++ b/drivers/core/device.c
@@ -243,14 +243,15 @@ int device_probe_child(struct udevice *dev, void *parent_priv)
                        goto fail;
        }
 
+       dev->flags |= DM_FLAG_ACTIVATED;
        if (drv->probe) {
                ret = drv->probe(dev);
-               if (ret)
+               if (ret) {
+                       dev->flags &= ~DM_FLAG_ACTIVATED;
                        goto fail;
+               }
        }
 
-       dev->flags |= DM_FLAG_ACTIVATED;
-
        ret = uclass_post_probe_device(dev);
        if (ret) {
                dev->flags &= ~DM_FLAG_ACTIVATED;