]> git.dujemihanovic.xyz Git - u-boot.git/commit
net: eth-phy: prevent undesired de-assertion of phy-reset on request
authorTim Harvey <tharvey@gateworks.com>
Tue, 1 Mar 2022 20:15:02 +0000 (12:15 -0800)
committerRamon Fried <ramon@neureality.ai>
Sun, 10 Apr 2022 05:44:13 +0000 (08:44 +0300)
commitf3409d7ae6127b6aa33ec9cdb63808745ed4b56e
tree8d93551f916f18eeedccee272780e5bc2ec519cb
parent4223fb0ee18d11462c55ac94198fdc2055f2c27c
net: eth-phy: prevent undesired de-assertion of phy-reset on request

When gpio_request_by_name allocates a gpio output it by default will
de-assert the gpio which for phy-reset will take the PHY out of reset.
As this occurs before eth_phy_reset is called to assert the reset
line it can cause undesired affects if reset timings are not properly
met.

Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active
(reset asserted) to avoid this.

Cc: Sean Anderson <sean.anderson@seco.com>
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
drivers/net/eth-phy-uclass.c