]> git.dujemihanovic.xyz Git - u-boot.git/commit
gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()
authorWolfgang Wallner <wolfgang.wallner@br-automation.com>
Mon, 3 Feb 2020 10:38:06 +0000 (11:38 +0100)
committerBin Meng <bmeng.cn@gmail.com>
Tue, 4 Feb 2020 04:54:55 +0000 (12:54 +0800)
commitea86e725d4c363232047126f1c84b03f13de7840
tree6bbceb89d75fb9117751d8a76236e0c1a1d2cd08
parent28c626804dee51dd89a5a400e0cb663ee9cc77ed
gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

Fix the following in intel_gpio_get_value():

 * The value of the register is contained in the variable 'reg', not in
   'mode'. The variable 'mode' contains only the configuration whether
   the gpio is currently an input or an output.

 * The correct bitmasks for the input and output value are
   PAD_CFG0_RX_STATE and PAD_CFG0_TX_STATE.
   Use them instead of the currently used PAD_CFG0_RX_STATE_BIT and
   PAD_CFG0_TX_STATE_BIT.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
drivers/gpio/intel_gpio.c