]> git.dujemihanovic.xyz Git - u-boot.git/commit
board: ti: common: board_detect: Fix EEPROM offset read for 1-byte
authorPrasanth Babu Mantena <p-mantena@ti.com>
Mon, 30 Oct 2023 17:04:58 +0000 (22:34 +0530)
committerTom Rini <trini@konsulko.com>
Wed, 24 Jan 2024 16:12:04 +0000 (11:12 -0500)
commitdd83c1c865f5bd94efae10d4a8e519ad08c8486b
tree08b7ac18dd297bfb67ff79c0d7019a9e878e18c7
parent15e7927b5a2d33666af19879577bf0c30ab088fe
board: ti: common: board_detect: Fix EEPROM offset read for 1-byte

EEPROM detection logic in ti_i2c_eeprom_get() involves reading
the total size and the 1-byte size with an offset 1. The commit
9f393a2d7af8 ("board: ti: common: board_detect: Fix EEPROM read
quirk for 2-byte") that attempts to fix this uses a wrong pointer to
compare.

The value with one offset is read into offset_test, but the pointer
used to match was still ep, resulting in an invalid comparison of the
values. The intent is to identify bad 2-byte addressing eeproms that
get stuck on the successive reads.

Fixes: 9f393a2d7af8 (board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte)
Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
Tested-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
board/ti/common/board_detect.c