]> git.dujemihanovic.xyz Git - u-boot.git/commit
i2c: designware_i2c: remove apparently redundant read of 'i2c, speeds' DT property
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Fri, 24 Mar 2023 08:09:22 +0000 (09:09 +0100)
committerHeiko Schocher <hs@denx.de>
Tue, 11 Apr 2023 04:43:33 +0000 (06:43 +0200)
commitd600b0fcbbfe877f67fb8b89e4d09aeb376c01d1
treed4b2ecb8498b4d583df76ee85deeb57990c96a8a
parent11c25c6df0b56ee7eee2c4ddc7f075880daeb8c7
i2c: designware_i2c: remove apparently redundant read of 'i2c, speeds' DT property

This code first figures out if there is an i2c,speeds property, if so
its size in u32s, and then reads the value into the local speeds[]
array. Both 'size' and 'speeds' are completely unused thereafter.

It's not at all clear what this is supposed to do. Of course, it could
be seen as a sanity check that the DT node does have an i2c,speeds
property with an appropriate number of elements, but for that one
wouldn't actually need to read it into speeds[]. Also, I can't find
anywhere else in the U-Boot code which makes use of values from that
property (this is is the only C code referencing "i2c,speeds"), so it
seems pointless to insist that it's there.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
drivers/i2c/designware_i2c_pci.c