]> git.dujemihanovic.xyz Git - u-boot.git/commit
arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code
authorHans de Goede <hdegoede@redhat.com>
Sat, 9 Apr 2016 11:53:48 +0000 (13:53 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 12 Apr 2016 00:48:26 +0000 (20:48 -0400)
commitc09d29057ab0b04db0857d319c6bff74de31b9c3
tree9f01964012e2eadce3e7d8e1b33e3d2e6d2264f9
parent456ecd08ec026e67a17a77baa3778c9f1b8e474d
arm: Replace v7_maint_dcache_all(ARMV7_DCACHE_CLEAN_INVAL_ALL) with asm code

v7_maint_dcache_all() does not work reliable when build with gcc6,
see: https://bugzilla.redhat.com/show_bug.cgi?id=1318788

While debugging this I learned that v7_maint_dcache_all() is unreliable
when build with gcc5 too when it is marked as noinline.

This commit fixes the reliability issues by replacing the C-code with
the ready to use asm implementation from the kernel.

Given that this code when written as C-code clearly is quite fragile
(also see the existing comments about the C-code being the way it is
 to get optimal assembly) and that we have a proven asm alternative,
I believe that this is the best solution.

Note that we actually already had a copy of the kernel's
v7_flush_dcache_all() before this commit in
arch/arm/mach-uniphier/arm32/lowlevel_init.S.

This commit moves that code arch/arm/cpu/armv7/cache_v7_asm.S, renames
it to __v7_flush_dcache_all(), and adds a v7_flush_dcache_all() wrapper
which saves / restores the clobbered registers for use from C-code.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
arch/arm/cpu/armv7/Makefile
arch/arm/cpu/armv7/cache_v7.c
arch/arm/cpu/armv7/cache_v7_asm.S [new file with mode: 0644]
arch/arm/mach-uniphier/arm32/lowlevel_init.S