]> git.dujemihanovic.xyz Git - u-boot.git/commit
musb-new, dfu: first send request answer then call completions
authorHeiko Schocher <hs@denx.de>
Thu, 10 Apr 2014 05:08:05 +0000 (07:08 +0200)
committerLukasz Majewski <l.majewski@samsung.com>
Thu, 8 May 2014 08:38:30 +0000 (10:38 +0200)
commitab2f5c12f7ca27b0191ebae90664182510330cd6
treef9e35bb708cdc115ab539425d07d1d38e6589579
parentdd5b68fba74371b40963f02d4c237163baa94865
musb-new, dfu: first send request answer then call completions

comment in ep0_txstate() states:

"report completions as soon as the fifo's loaded; there's no win
 in waiting till this last packet gets acked".

This is wrong for using dfu. In the dfu usecase we must send
a PollTimeout to the host, so the host can wait until the
U-Boot Code is ready for answering new usb requests. So the
answer which contains the PollTimeout must send *before*
U-Boot calls req->complete.

The req->complete is used in the dfu case for flushing the
medium, when entering DFU_STATE_dfuMANIFEST_SYNC state.

Change-Id: Ib2941119c72761e48e15fedbdad1ecce07ae0b3d
Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
Acked-by: Marek Vasut <marex@denx.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
drivers/usb/musb-new/musb_gadget_ep0.c