]> git.dujemihanovic.xyz Git - u-boot.git/commit
cmd: sata: fix init command return value
authorGary Bisson <gary.bisson@boundarydevices.com>
Wed, 11 Jan 2017 15:51:53 +0000 (16:51 +0100)
committerTom Rini <trini@konsulko.com>
Sat, 14 Jan 2017 21:46:23 +0000 (16:46 -0500)
commit8547f45bc54b1a96bfa539f3e1070c5046c54764
treea371e51ad968d3894d4fbdf8acf25e90c9f8f8ab
parent7f73ca484f792a0d2a7ee09860c32f3d02b3030d
cmd: sata: fix init command return value

Since commit aa6ab905b2, sata_initialize returns -1 if init_sata or
scan_sata fails. But this return value becomes the do_sata return
value which is equivalent to CMD_RET_USAGE.

In case one issues 'sata init' and that the hardware fails to
initialize, there's no need to display the command usage. Instead
the command shoud just return the CMD_RET_FAILURE value.

Fixes: aa6ab905b2 (sata: fix sata command can not being executed bug)
Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
Reviewed-by: Eric Nelson <eric@nelint.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
cmd/sata.c